fix(last_insert_rowid): publish rowid from cached_write + fall back to real SQLite when pg_conn lookup misses#13
Draft
JorisM wants to merge 2 commits into
Draft
fix(last_insert_rowid): publish rowid from cached_write + fall back to real SQLite when pg_conn lookup misses#13JorisM wants to merge 2 commits into
JorisM wants to merge 2 commits into
Conversation
…LICT DO UPDATE Plain INSERT into shim-added UNIQUE-keyed tables (statistics_bandwidth, statistics_media, metadata_item_settings) raises unique_violation on PG; PMS does not catch and aborts with DB::Exception. Extend transform_insert to emit ON CONFLICT DO UPDATE for plain INSERTs whose target table has known conflict columns. DO UPDATE (not DO NOTHING) is intentional so the trailing RETURNING id clause in cached_write still returns the row id. Verified via cargo run --example crash_repro and live pilot pod.
…o real SQLite when pg_conn lookup misses Bug #3a: Cached INSERT … RETURNING id never published the row id to Plex's sqlite3_last_insert_rowid view. cached_write now mirrors the non-cached write path: writes ec.last_insert_rowid and calls rust_set_global_last_insert_rowid after a successful exec. Bug #3b: last_insert_rowid_impl returned 0 when the registry lookup missed AND the global was 0 — never fell back to the real shadow SQLite. Added orig_sqlite3_last_insert_rowid(db) fallback so the shadow's view is the source of truth in that path. Required import added in db_interpose_metadata.rs. Verified live: EXCEPTION counter stays at 0 across the 5s stats roll-up cycle; `real_sqlite=N` log markers + `global=N` ticking with N>0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft pending live pilot verification. Stacks on #2 (rewrite-plain-INSERT). Surfaces only after #2 is in.
Two related issues:
Detailed write-up: docs/debug/plex-pg-db-exception-bug-report.md.